netdev - Re: [PATCH v7 10/33] net: dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pphdh85q.fsf@nemi.mork.no>
Date:	Thu, 10 Jul 2014 11:31:29 +0200
From:	Bjørn Mork <bjorn@...k.no>
To:	Tom Gundersen <teg@...m.no>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	David Herrmann <dh.herrmann@...il.com>,
	Kay Sievers <kay@...y.org>,
	dingtianhong <dingtianhong@...wei.com>,
	Tan Xiaojun <tanxiaojun@...wei.com>,
	WANG Cong <xiyou.wangcong@...il.com>
Subject: Re: [PATCH v7 10/33] net: dummy - set name assign type

Tom Gundersen <teg@...m.no> writes:

> A fixed number of indistinguishable dummy devices are allocated at module init time,
> the names are therefore PREDICTABLE rather than ENUM.

OK?  So if I go do

 modprobe dummy numdummies=2
 ip link add type dummy
 ip link add type dummy

then I'd have dummy0 and dummy1 with NET_NAME_PREDICTABLE, but dummy2 and
dummy3 with NET_NAME_ENUM (from your rtnetlink patch).

I think this just demonstrates that there aren't that many different
name types.  There is no real difference between your NET_NAME_ENUM and
NET_NAME_PREDICTABLE, resulting in arbitrary choices like this one.

The same goes for NET_NAME_USER and NET_NAME_RENAMED. These are the same
from a kernel point of view.  If userspace wants to keep track of device
name history then it is free to do so without any need for a RENAMED
type.

Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html