netdev - Question about settings array in phy.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C007E3.4010009@amd.com>
Date:	Fri, 11 Jul 2014 10:50:59 -0500
From:	Tom Lendacky <thomas.lendacky@....com>
To:	netdev <netdev@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>
CC:	David Miller <davem@...emloft.net>
Subject: Question about settings array in phy.c

In drivers/net/phy/phy.c there is an array of struct phy_setting named
settings that is used when auto negotiation is disabled to sanitize
the phy settings.  This array uses only *baseT* features for validating
the various speed/duplex combinations.  This may result in not finding
the correct array entry in regards to speed and duplex if the *baseT*
feature is not supported.

For example, a 10GbE phy that supports KR mode would end up not matching
an entry and defaulting to the last entry of the array (SPEED_10 and
DUPLEX_HALF) which is not what is desired.

Is it appropriate to be able to extend this array?  Either by adding
additional array entries or extending the "setting" to include other
features?  Or is there a specific reason that only the *baseT* values
are used?

Examples of changing the array:

   Add a new entry
	{
		.speed = SPEED_10000,
		.duplex = DUPLEX_FULL,
		.setting = SUPPORTED_10000baseKR_Full,
	},

   or extend current entry
	{
		.speed = SPEED_10000,
		.duplex = DUPLEX_FULL,
		.setting = SUPPORTED_10000baseT_Full |
			   SUPPORTED_10000baseKR_Full,
	},

Thanks,
Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html