netdev - Re: [PATCH net-next 02/11] net: bcmgenet: add umac_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140711.133956.1369622097201965432.davem@davemloft.net>
Date:	Fri, 11 Jul 2014 13:39:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 02/11] net: bcmgenet: add umac_enable_set
 helper

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 10 Jul 2014 15:46:15 -0700

> +static void umac_enable_set(struct bcmgenet_priv *priv, u32 mask,
> +				unsigned int enable)

'enable' is strictly used as a boolean, so please use 'bool' and
true/false, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html