netdev - Re: [PATCH] bfin_mac: convert bfin Ethernet driver to NAPI framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2014 12:57:10 +0800
From:	Sonic Zhang <sonic.adi@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	"Zhang, Sonic" <sonic.zhang@...log.com>
Subject: Re: [PATCH] bfin_mac: convert bfin Ethernet driver to NAPI framework

Hi David,

On Fri, Jul 11, 2014 at 7:53 AM, David Miller <davem@...emloft.net> wrote:
> From: Sonic Zhang <sonic.adi@...il.com>
> Date: Thu, 10 Jul 2014 17:52:24 +0800
>
>> +     if (i < budget && !test_bit(NAPI_STATE_NPSVC, &napi->state)) {
>> +             napi_complete(napi);
>> +             enable_irq(IRQ_MAC_RX);
>> +     }
>
> Drivers are not supposed to test this bit directly.
>
> If you have not exhausted the budget, and the chip has no more work to
> do, you should unconditionally exit the NAPI poll.

OK. I will send a new patch.

Regards,

Sonic
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html