netdev - Re: [PATCH net-next] ipv6: fix the debug information in icmpv6_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BF8816.8010400@miraclelinux.com>
Date:	Fri, 11 Jul 2014 15:45:42 +0900
From:	YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
To:	roy.qing.li@...il.com, netdev@...r.kernel.org
CC:	hideaki.yoshifuji@...aclelinux.com
Subject: Re: [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup

Hi,

roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> it should be "anycast destination", not "anycast source"
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>   net/ipv6/icmp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
> index f6c84a6..481fd5a 100644
> --- a/net/ipv6/icmp.c
> +++ b/net/ipv6/icmp.c
> @@ -334,7 +334,7 @@ static struct dst_entry *icmpv6_route_lookup(struct net *net,
>   	 * anycast.
>   	 */
>   	if (((struct rt6_info *)dst)->rt6i_flags & RTF_ANYCAST) {
> -		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast source\n");
> +		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast destination\n");
>   		dst_release(dst);
>   		return ERR_PTR(-EINVAL);
>   	}
> 

No.
It is used by icmp6_send() and it means icmp6_send() won't
send back to the original "anycast" source addresses.

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html