netdev - RE: [PATCH v2 net-next 0/3] net: sctp: Add partial MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2014 08:39:32 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'David Miller' <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>,
	"vyasevich@...il.com" <vyasevich@...il.com>,
	"nhorman@...driver.com" <nhorman@...driver.com>
Subject: RE: [PATCH v2 net-next 0/3] net: sctp: Add partial MSG_MORE support
 to SCTP

From: David Miller 
> From: David Laight <David.Laight@...LAB.COM>
> Date: Wed, 9 Jul 2014 08:29:11 +0000
> 
> > If an application has disabled Nagle then it is almost impossible
> > to get more than one DATA chunk into an ethernet packet even if
> > the application has more than one data chunk ready to transmit.
> >
> > This could be fixed by adding an SCTP_CORK socket option - but
> > using that requires a lot of system calls.
> > An alternative is to honour MSG_MORE - using it to mean that
> > another chunk will be sent soon.
> > (There isn't much point using MSG_MORE to allow a chunk be extended,
> > sendv() can be used for fragmented data.)
> >
> > This is a partial implementation and takes a couple of shortcuts:
> > 1) We only worry about whether MSG_MORE was set on the last send.
> >    Data sent (by the application) with MSG_MORE unset will only be
> >    unsent for flow control reasons.
> >    So if the last send had MSG_MORE set, and an ack opens the window
> >    then the unsent data won't be sent immediately.
> >
> > 2) If the application doesn't do a send with MSG_MORE unset, then
> >    buffered data shouldn't be buffered forever.
> >    Rather than using a timer (as TCP does - which ought to be configurable
> >    on a per-socket basis) we use the same rules as Nagle and ensure
> >    that there is always some data outstanding.
> >    This does mean that the first data chunk on an idle connection
> >    is send in its own packet even if MSG_MORE is set.
> 
> I need some SCTP experts to review this series, thanks.

One thing that makes it easier, is that there is only one conditional
in the entire sctp stack that checks whether Nagle is enabled.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html