netdev - Re: [patch net-next] ipv6: addrconf: implement address generation modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53BFAB57.10700@miraclelinux.com>
Date:	Fri, 11 Jul 2014 18:16:07 +0900
From:	YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
CC:	hideaki.yoshifuji@...aclelinux.com, davem@...emloft.net,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, sfeldma@...ulusnetworks.com,
	arvid.brodin@...en.se, sucheta.chakraborty@...gic.com,
	hannes@...essinduktion.org
Subject: Re: [patch net-next] ipv6: addrconf: implement address generation
 modes

Hi,

Jiri Pirko wrote:
> This patch introduces a possibility for userspace to set various (so far
> two) modes of generating addresses. This is useful for example for
> NetworkManager because it can set the mode to NONE and take care of link
> local addresses itself. That allow it to have the interface up,
> monitoring carrier but still don't have any addresses on it.
> 
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
> ---
>   include/net/if_inet6.h       |  1 +
>   include/uapi/linux/if_link.h |  6 +++++
>   net/ipv6/addrconf.c          | 56 ++++++++++++++++++++++++++++++--------------
>   3 files changed, 45 insertions(+), 18 deletions(-)
> 
> diff --git a/include/net/if_inet6.h b/include/net/if_inet6.h
> index b4956a5..f82b281 100644
> --- a/include/net/if_inet6.h
> +++ b/include/net/if_inet6.h
> @@ -206,6 +206,7 @@ struct inet6_dev {
>   	__u8			rs_probes;
>   
>   	unsigned long		tstamp; /* ipv6InterfaceTable update timestamp */
> +	enum in6_addr_gen_mode	addr_gen_mode;

How about putting this as __u8 after dad_probes?

> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 358edd2..2c75ec1 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2730,9 +2730,25 @@ static void addrconf_add_linklocal(struct inet6_dev *idev, const struct in6_addr
>   	}
>   }
>   
> +static void addr_conf_addr_gen(struct inet6_dev *idev, bool prefix_route)

s/addr_conf/addrconf/

-- 
Hideaki Yoshifuji <hideaki.yoshifuji@...aclelinux.com>
Technical Division, MIRACLE LINUX CORPORATION
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html