lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 13 Jul 2014 00:31:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH net-next] enic: Add ethtool support to show classifier
 filters added by the driver

From: Govindarajulu Varadarajan <_govind@....com>
Date: Sat, 12 Jul 2014 14:09:15 +0530 (IST)

> On Fri, 11 Jul 2014, David Miller wrote:
> 
>> From: Govindarajulu Varadarajan <_govind@....com>
>> Date: Fri, 11 Jul 2014 14:44:11 +0530
>>
>>> Right now Accelerated RFS is the only feature which adds classifier
>>> filters.
>>> So enable get_rxnfc only when CONFIG_RFS_ACCEL = y
>> ...
>>> @@ -293,6 +389,9 @@ static const struct ethtool_ops enic_ethtool_ops =
>>> {
>>>  	.get_ethtool_stats = enic_get_ethtool_stats,
>>>  	.get_coalesce = enic_get_coalesce,
>>>  	.set_coalesce = enic_set_coalesce,
>>> +#ifdef CONFIG_RFS_ACCEL
>>> +	.get_rxnfc = enic_get_rxnfc,
>>> +#endif
>>
>> No other driver protects this method in this way, please don't do
>> this.
>>
> 
> I will move the ifdef's to .h files and resubmit.

I meant, at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists