netdev - Re: [PATCH] neigh: sysctl - simplify address calculation of gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140714.143318.1099738757410344842.davem@davemloft.net>
Date:	Mon, 14 Jul 2014 14:33:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	minipli@...glemail.com
Cc:	netdev@...r.kernel.org, spender@...ecurity.net
Subject: Re: [PATCH] neigh: sysctl - simplify address calculation of gc_*
 variables

From: Mathias Krause <minipli@...glemail.com>
Date: Sat, 12 Jul 2014 22:36:44 +0200

> The code in neigh_sysctl_register() relies on a specific layout of
> struct neigh_table, namely that the 'gc_*' variables are directly
> following the 'parms' member in a specific order. The code, though,
> expresses this in the most ugly way.
> 
> Get rid of the ugly casts and use the 'tbl' pointer to get a handle to
> the table. This way we can refer to the 'gc_*' variables directly.
> 
> Similarly seen in the grsecurity patch, written by Brad Spengler.
> 
> Signed-off-by: Mathias Krause <minipli@...glemail.com>
> Cc: Brad Spengler <spender@...ecurity.net>

Looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html