netdev - RE: [PATCH v2 net-next 1/3] net: sctp: Open out the check for Nagle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D172719BD@AcuExch.aculab.com>
Date:	Mon, 14 Jul 2014 09:12:33 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Vlad Yasevich' <vyasevich@...il.com>,
	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
	"'linux-sctp@...r.kernel.org'" <linux-sctp@...r.kernel.org>
CC:	"'davem@...emloft.net'" <davem@...emloft.net>
Subject: RE: [PATCH v2 net-next 1/3] net: sctp: Open out the check for Nagle

From: Vlad Yasevich
...
> > +	if (inflight != 0)
> > +		/* Nothing unacked */
> > +		return SCTP_XMIT_OK;
> 
> This doesn't look right.  First, the comment doesn't match the condition.
> Second, when we have stuff in-flight we might be affected be Nagle.  Thus,
> I think the condition should be:
>        if (!inflight)
> 
> Then the commend and logic holds.

Gah, I accidentally inverted the condition :-(
I changed it to a an explicit comparison because 'inflight' is actually
the number of bytes that are unacked.

I'll repost the series later in the week.

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html