netdev - napi and softirq sticking (stuck) solution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C3A993.4050007@gmail.com>
Date:	Mon, 14 Jul 2014 13:57:39 +0400
From:	"p.kosyh" <p.kosyh@...il.com>
To:	netdev@...r.kernel.org
Subject: napi and softirq sticking (stuck) solution

Hello!

There is one problem (well known?) we have with napi and softirq 
sticking while irq balancing.
We are solved this problem so may be someone will find this information 
useful.

For example, we have some multi-queue ethernet devices. Each tx/rx-queue 
uses own irq.
Lets assume that at start we have not optimal irq affinity and some 
queues irq are
binded to the same CPU.

Then we have a heavy load traffic. So, some irqs are on (for example) 
CPU#1. And we have
100% softirq on that CPU#1. Ethernet driver is working in napi mode, 
because there are always
a lot of packets in queues to poll.

Here, we want to make affinity better!

irq affinity in our situation is managed in realtime by irq balancer. 
There are no many balancers.
We found, that irqbalance and irqd sometimes do fuzzy logic, so, we have 
developed own
balancer that works well. Here it is: http://birq.libcode.org

But we can reproduce problem without balancer, just echo affinity in 
smp_affinity proc entries under
heavy load.

Anyway, under heavy load, after changing smp_affinity we stays with 100% 
softirq at CPU#1, just
because we are still in polling mode (irq disabled) and napi object is 
always scheduled on same CPU#1.

So, under heavy traffic, the irq ballancing is not works at all.

To solve this problem we just break napi mode sometimes in network driver.
For example, e1000e/netdev.c

In e1000e_poll function:
=============
         if (time_is_before_jiffies(adapter->napi_stamp + 
usecs_to_jiffies(netdev_napi_limit)))
                 work_done = 0;
...
         /* If weight not fully consumed, exit the polling mode */
                 if (work_done < weight) {
=============

So, every 1 sec (for example) we are breaking napi mode, and softirq 
will move on another CPU (according smp_affinity).

The bad thing is that we have to patch every network driver. But without 
this we can not use Linux as good router.

So, i hope, this text will be useful.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html