netdev - RE: [PATCH 1/2] net: cadence: macb: add support for the WOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17271AC1@AcuExch.aculab.com>
Date:	Mon, 14 Jul 2014 10:49:04 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Varka Bhadram' <varkabhadram@...il.com>,
	Jongsung Kim <neidhard.kim@....com>,
	"nicolas.ferre@...el.com" <nicolas.ferre@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [PATCH 1/2] net: cadence: macb: add support for the WOL

From: Varka Bhadram
> On 07/14/2014 02:32 PM, Jongsung Kim wrote:
> > This patch enables the ethtool utility to control the WOL function
> > of the PHY connected to the GEM/MACB. (if supported)
...
> > +static int macb_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
> > +{
> > +	struct macb *bp = netdev_priv(netdev);
> > +	struct phy_device *phydev = bp->phy_dev;
> > +	int err = -ENODEV;
> > +
> > +	if (phydev)
> > +		err = phy_ethtool_set_wol(phydev, wol);
> > +
> > +	return err;
> > +}
> > +
> 
> I think we can do in this way:
> 
> if (phydev)
> 	return phy_ethtool_set_wol(phydev, wol);
> else
> 	return -ENODEV;
> 
> 
> we can save err. What do you say ...?

I would do:
	if (!phydev)
		return -ENODEV;
	return phy_ethtool_set_wol(phydev, wol);

Although it might even be worth moving the NULL test into the function.
(sort of depends on style and the number of callers who need to do the test.)

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html