netdev - Re: [PATCH net-next] bonding: fix bond_option_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53C5371D.9060003@redhat.com>
Date:	Tue, 15 Jul 2014 16:13:49 +0200
From:	Nikolay Aleksandrov <nikolay@...hat.com>
To:	netdev@...r.kernel.org
CC:	Stephen Hemminger <stephen@...workplumber.org>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Veaceslav Falico <vfalico@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] bonding: fix bond_option_mode_set warning

On 07/15/2014 04:08 PM, Nikolay Aleksandrov wrote:
> During the conversion to "static" functions this one got left out, only its
> prototype was converted, thus resulting in:
> drivers/net/bonding//bond_options.c:674:5: warning: symbol
> 'bond_option_mode_set' was not declared. Should it be static?
> 
> Fix it by making it static and also break the line in two as it was too
> long.
> 
> CC: Stephen Hemminger <stephen@...workplumber.org>
> CC: Jay Vosburgh <j.vosburgh@...il.com>
> CC: Veaceslav Falico <vfalico@...il.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: David S. Miller <davem@...emloft.net>
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>
> ---

Just FYI, I targeted this at net-next as it's more cosmetic and there aren't any
real side-effects because of it. In case you decide it's more appropriate for
-net, the commit that did this was:
f3253339a47f ("bonding: options handling cleanup")

and I tested that this patch applies cleanly to -net, so it's fit for there too.

Cheers,
 Nik

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html