netdev - Re: [PATCH v2 net-next 0/4] bonding: rcu cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140715143714.GB5225@mikrodark.usersys.redhat.com>
Date:	Tue, 15 Jul 2014 16:37:15 +0200
From:	Veaceslav Falico <vfalico@...il.com>
To:	Eric Dumazet <edumazet@...gle.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH v2 net-next 0/4] bonding: rcu cleanups

On Tue, Jul 15, 2014 at 06:56:52AM -0700, Eric Dumazet wrote:
>RCU was added to bonding in linux-3.12 but lacked proper sparse annotations.
>
>Using __rcu annotation actually helps to spot all accesses to
>bond->curr_active_slave & cond->current_arp_slave
>are correctly protected, with full sparse & LOCKDEP support.
>
>Lets clean the code.

Awesome work, thank you!

Acked-by: Veaceslav Falico <vfalico@...il.com>

>
>Eric Dumazet (4):
>  bonding: get rid of bond_option_active_slave_get()
>  bonding: use rcu_access_pointer() in bonding_show_mii_status()
>  bonding: add proper __rcu annotation for curr_active_slave
>  bonding: add proper __rcu annotation for current_arp_slave
>
> drivers/net/bonding/bond_alb.c     | 47 +++++++++++++++-----------
> drivers/net/bonding/bond_main.c    | 68 +++++++++++++++++++++-----------------
> drivers/net/bonding/bond_netlink.c | 21 +++++++++---
> drivers/net/bonding/bond_options.c |  7 +---
> drivers/net/bonding/bond_sysfs.c   |  3 +-
> drivers/net/bonding/bonding.h      |  9 +++--
> 6 files changed, 91 insertions(+), 64 deletions(-)
>
>-- 
>2.0.0.526.g5318336
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html