netdev - RE: [PATCH v6 ethtool 0/2] patchset - Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0356375-ac11-4291-9848-e6807c5a8ce9@CMEXHTCAS1.ad.emulex.com>
Date:	Tue, 15 Jul 2014 15:24:18 +0000
From:	Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
To:	"ben@...adent.org.uk" <ben@...adent.org.uk>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Venkat Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
Subject: RE: [PATCH v6 ethtool 0/2] patchset - Support for configurable RSS
 hash key

Ben, 
Are there any  review comments on this patchset?

/Venkat.

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of Venkat Duvvuru
> Sent: Friday, June 06, 2014 9:21 PM
> To: ben@...adent.org.uk
> Cc: netdev@...r.kernel.org; Venkat Duvvuru
> Subject: [PATCH v6 ethtool 0/2] patchset - Support for configurable RSS hash
> key
> 
> NIC drivers that support RSS use either a hard-coded value or a random value
> for the RSS hash key. Irrespective of the type of the key used, the user
> would want to change the hash key if he/she is not satisfied with the
> effectiveness of the default hash-key in spreading the incoming flows evenly
> across the RSS queues.
> 
> This patch set adds support for configuring the RSS hash-key via the ethtool
> interface using .X/-x option.
> 
> v6:
> 1. Addressed Ben's comments.
> 2. Fixed memory leaks in do_grxfhindir, do_srxfhindir, do_srxfh, do_grxfh.
> 3. Handled memory allocation failures in do_grxfhindir, do_srxfhindir,
> do_srxfh, do_grxfh.
> 
> Venkat Duvvuru (2):
>   ethtool: Support for configurable RSS hash key
>   ethtool: Support for configurable RSS hash key
> 
>  ethtool-copy.h |  478
> ++++++++++++++++++++++++++++++++++++++++++--------------
>  ethtool.8.in   |   18 ++-
>  ethtool.c      |  390 ++++++++++++++++++++++++++++++++++++++--------
>  3 files changed, 703 insertions(+), 183 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html