netdev - Re: [PATCH net-next v2 01/11] openvswitch: Allow each vport to have an array of 'port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+qFW=4A24N=tbLei-3A3JO=qW2GWJvfJPJiwUCfLehpQQ@mail.gmail.com>
Date:	Tue, 15 Jul 2014 11:16:01 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Nikolay Aleksandrov <nikolay@...hat.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Alex Wang <alexw@...ira.com>
Subject: Re: [PATCH net-next v2 01/11] openvswitch: Allow each vport to have
 an array of 'port_id's.

On Tue, Jul 15, 2014 at 10:31 AM, Nikolay Aleksandrov
<nikolay@...hat.com> wrote:
> <snip>
>> +/**
>> + *   ovs_vport_set_upcall_portids - set upcall portids of @vport.
>> + *
>> + * @vport: vport to modify.
>> + * @ids: new configuration, an array of port ids.
>> + *
>> + * Sets the vport's upcall_portids to @ids.
>> + *
>> + * Returns 0 if successful, -EINVAL if @ids is zero length or cannot be parsed
>> + * as an array of U32.
>> + *
>> + * Must be called with ovs_mutex.
>> + */
>> +int ovs_vport_set_upcall_portids(struct vport *vport,  struct nlattr *ids)
>> +{
>> +     struct vport_portids *old, *vport_portids;
>> +
>> +     if (!nla_len(ids) || nla_len(ids) % sizeof(u32))
>> +             return -EINVAL;
>> +
>> +     old = ovsl_dereference(vport->upcall_portids);
>> +
>> +     vport_portids = kmalloc(sizeof(*vport_portids) + nla_len(ids),
>> +                             GFP_KERNEL);
> ^^^^^^^
> Shouldn't there be a null check after the kmalloc instead of directly
> dereferencing vport_portids ?
>
right, I will update the patch.

>> +     vport_portids->n_ids = nla_len(ids) / sizeof(u32);
>> +     vport_portids->rn_ids = reciprocal_value(vport_portids->n_ids);
>> +     nla_memcpy(vport_portids->ids, ids, nla_len(ids));
>> +
>> +     rcu_assign_pointer(vport->upcall_portids, vport_portids);
>> +
>> +     if (old)
>> +             call_rcu(&old->rcu, vport_portids_destroy_rcu_cb);
>> +
>> +     return 0;
>> +}
> <snip>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html