netdev - Re: [PATCH net v2] bonding: enhance L2 hash helper with packet type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1405411536.10255.15.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 15 Jul 2014 10:05:36 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Xie Jianhua <Jianhua.Xie@...escale.com>
Cc:	netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
	Veaceslav Falico <vfalico@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S. Miller" <davem@...emloft.net>,
	Pan Jiafei <Jiafei.Pan@...escale.com>
Subject: Re: [PATCH net v2] bonding: enhance L2 hash helper with packet type

On Tue, 2014-07-15 at 15:41 +0800, Xie Jianhua wrote:
> From: Jianhua Xie <jianhua.xie@...escale.com>
> 
> Current L2 hash helper calculates destination eth addr and
> source ether addr as L2 hash factors. This patch is adding
> packet type ID field into hash factors, which can help to
> distribute different types of packets like IPv4/IPv6 packets
> to different slave devices while only BOND_XMIT_POLICY_LAYER2
> is applied.
> 
> CC: Jay Vosburgh <j.vosburgh@...il.com>
> CC: Veaceslav Falico <vfalico@...il.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: David S. Miller <davem@...emloft.net>
> CC: Pan Jiafei <Jiafei.Pan@...escale.com>
> 
> Suggested-by: David S. Miller <davem@...emloft.net>

I do not think this patch was suggested by David.

He suggested to use skb_header_pointer() which is an implementation
detail.

Anyway, patch looks fine, even if bond_eth_hash() is no longer a leaf
function.

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html