netdev - Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140714.192758.1087918241017989929.davem@davemloft.net>
Date:	Mon, 14 Jul 2014 19:27:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	olivier@...rie.be
Cc:	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, David.Laight@...LAB.COM,
	gnomes@...rguk.ukuu.org.uk, dcbw@...hat.com, j.dumon@...ion.com
Subject: Re: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

From: Olivier Sobrie <olivier@...rie.be>
Date: Mon, 14 Jul 2014 12:08:50 +0200

> When the module sends bursts of data, sometimes a deadlock happens in
> the hso driver when the tty buffer doesn't get the chance to be flushed
> quickly enough.
> 
> Remove the endless while loop in function put_rxbuf_data() which is
> called by the urb completion handler.
> If there isn't enough room in the tty buffer, discards all the data
> received in the URB.
> 
> Cc: David Miller <davem@...emloft.net>
> Cc: David Laight <David.Laight@...LAB.COM>
> Cc: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
> Cc: Dan Williams <dcbw@...hat.com>
> Cc: Jan Dumon <j.dumon@...ion.com>
> Signed-off-by: Olivier Sobrie <olivier@...rie.be>
> ---
> Changes in v2:
>  - remove the unthrottle timer added in the previous patch version
>  - drop entire rx urb data if there is not enough space in tty buffer
>  - remove variable curr_rx_urb_offset from hso_serial structure

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html