netdev - Re: [PATCH v5] bfin_mac: convert bfin Ethernet driver to NAPI framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140716.140301.896018835447121717.davem@davemloft.net>
Date:	Wed, 16 Jul 2014 14:03:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	sonic.adi@...il.com, netdev@...r.kernel.org,
	varkabhadram@...il.com, adi-buildroot-devel@...ts.sourceforge.net,
	sonic.zhang@...log.com
Subject: Re: [PATCH v5] bfin_mac: convert bfin Ethernet driver to NAPI
 framework

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 16 Jul 2014 15:17:29 +0200

> On Wed, 2014-07-16 at 17:51 +0800, Sonic Zhang wrote:
>> From: Sonic Zhang <sonic.zhang@...log.com>
>> +	if (i < budget) {
>> +		napi_gro_flush(napi, false);
>> +		local_irq_save(flags);
>> +		__napi_complete(napi);
>> +		local_irq_restore(flags);
>> +		enable_irq(IRQ_MAC_RX);
> 
> I have no idea why you open-code napi_complete();
> 
> Why cant you just copy/paste what other drivers do here ?
> 
> 	if (i < budget) {
> 		napi_complete(napi);
> 		enable_irq(IRQ_MAC_RX);
> 	}

Generally speaking, I am very frustrated at how this bfin_mac NAPI
conversion tries to do things in special ways.

Please mimick what other drivers do rather than trying to do things in
a special way unique to your driver.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html