netdev - RE: [PATCH net-next 3/7] tipc: add new functions for multicast and broadcast distribution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A2BAEFC30C8FD34388F02C9B3121859D1C289DE7@eusaamb103.ericsson.se>
Date:	Wed, 16 Jul 2014 22:21:04 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	Erik Hugne <erik.hugne@...csson.com>,
	"ying.xue@...driver.com" <ying.xue@...driver.com>,
	"maloy@...jonn.com" <maloy@...jonn.com>,
	"tipc-discussion@...ts.sourceforge.net" 
	<tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH net-next 3/7] tipc: add new functions for multicast and
 broadcast distribution



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: July-16-14 6:11 PM
> To: Jon Maloy
> Cc: netdev@...r.kernel.org; paul.gortmaker@...driver.com; Erik Hugne;
> ying.xue@...driver.com; maloy@...jonn.com; tipc-
> discussion@...ts.sourceforge.net
> Subject: Re: [PATCH net-next 3/7] tipc: add new functions for multicast and
> broadcast distribution
> 
> From: Jon Maloy <jon.maloy@...csson.com>
> Date: Tue, 15 Jul 2014 13:46:06 -0400
> 
> > +	/* Copy header if single buffer */
> > +	if (!buf->next) {
> > +		hdr_sz = skb_headroom(buf) + msg_hdr_sz(buf_msg(buf));
> > +		head = __pskb_copy(buf, hdr_sz, GFP_ATOMIC);
> > +		if (likely(head))
> > +			return head;
> > +		return NULL;
> 
> These last four lines are simply:
> 
> 		return __pskb_copy(buf, hdr_sz, GFP_ATOMIC);
> 
> Don't make this code more complicated than necessary :)

Uhh...  Of course.  I think I changed this code back and forth too many times.
If that is all,  I'll post the series again asap.

///jon
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html