netdev - Re: [PATCH net-next] cxgb4: Fix static checker warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140716.154542.601722446325914197.davem@davemloft.net>
Date:	Wed, 16 Jul 2014 15:45:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	anish@...lsio.com
Cc:	netdev@...r.kernel.org, leedom@...lsio.com, hariprasad@...lsio.com,
	dan.carpenter@...cle.com
Subject: Re: [PATCH net-next] cxgb4: Fix static checker warnings 

From: Anish Bhatt <anish@...lsio.com>
Date: Tue, 15 Jul 2014 12:17:23 -0700

> This patch fixes static checker warnings as pointed out on by Dan Carpenter
> 
> Fixes: 76bcb31efc06 ("cxgb4 : Add DCBx support codebase  and dcbnl_ops")
> Signed-off-by: Anish Bhatt <anish@...lsio.com>

The real bug here is more likely, as Casey Leedom said, that the method
returns u8 instead of int.

The only other implementation of this method, bnx2x, also tries to return
negative error codes.

So please just change the return type in the method signature and the
two implementations.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html