netdev - Re: [PATCH net-next 0/2] bonding: add its own Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140716072032.GA12030@mikrodark.usersys.redhat.com>
Date:	Wed, 16 Jul 2014 09:20:32 +0200
From:	Veaceslav Falico <vfalico@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, j.vosburgh@...il.com, andy@...yhouse.net
Subject: Re: [PATCH net-next 0/2] bonding: add its own Kconfig

On Tue, Jul 15, 2014 at 06:10:56PM -0700, David Miller wrote:
>From: Veaceslav Falico <vfalico@...il.com>
>Date: Tue, 15 Jul 2014 12:15:39 +0200
>
>> Currently to change some built-in defaults it's necessary to change the
>> code, and to maintain these patches on each update.
>>
>> Create a bonding's Kconfig to make it possible to configure them at build
>> time.
>
>There is really no reason these values can't be set at run time, and that
>is my only, but firm, objection to this patch series.

Yeah, MIIMON default value doesn't really need to exist, vlan depth can be
configured dynamically ...

>
>For the per-slave things, make new netlink attributes that can be provided
>when the slave is added, using the existing default if not specified.
>
>This means the fixed sized arrays involved here need to become
>dynamically allocated.

... and arp ip targets can be also made into lists.

I'll try to change it and come up with split patchsets.

Thank you!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html