lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Jul 2014 16:25:35 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Will Deacon' <will.deacon@....com>, Zi Shen Lim <zlim.lnx@...il.com> CC: Catalin Marinas <Catalin.Marinas@....com>, Jiang Liu <liuj97@...il.com>, AKASHI Takahiro <takahiro.akashi@...aro.org>, "David S. Miller" <davem@...emloft.net>, Daniel Borkmann <dborkman@...hat.com>, "Alexei Starovoitov" <ast@...mgrid.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: RE: [PATCH RFCv3 08/14] arm64: introduce aarch64_insn_gen_movewide() From: Will Deacon ... > > + BUG_ON(imm < 0 || imm > 65535); > > Do this check with masking instead? The compiler will convert that to a single unsigned comparison. ... > > + BUG_ON(shift != 0 && shift != 16 && shift != 32 && > > + shift != 48); OTOH I don't think it will convert that to: BUG_ON(shift & ~48); David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists