netdev - Re: [PATCH net-next 1/2] net: use dev->name in netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140717143001.GB28357@mikrodark.usersys.redhat.com>
Date:	Thu, 17 Jul 2014 16:30:01 +0200
From:	Veaceslav Falico <vfalico@...il.com>
To:	Tom Gundersen <teg@...m.no>
Cc:	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 1/2] net: use dev->name in netdev_pr* when it's
 available

On Thu, Jul 17, 2014 at 04:29:21PM +0200, Tom Gundersen wrote:
>On Thu, Jul 17, 2014 at 4:01 PM, Veaceslav Falico <vfalico@...il.com> wrote:
>> On Thu, Jul 17, 2014 at 03:48:45PM +0200, Tom Gundersen wrote:
>>>
>>> On Thu, Jul 17, 2014 at 1:28 PM, Veaceslav Falico <vfalico@...il.com>
>>> wrote:
>>>>
>>>> e() returns dev->name only when the net_device is in
>>>> NETREG_REGISTERED state.
>>>>
>>>> However, dev->name is always populated on creation, so we can easily use
>>>> it. The only caveat is that the device still has a name of type "eth%d",
>>>> in
>>>> which case we cannot use this name as it'll change in the nearest future,
>>>> thus return "unnamed net_device".
>>>
>>>
>>> There are also cases when the name is set to emptystring before being
>>> populated with the real name later on. You may want to check for that
>>> too.
>>
>>
>> Sure, it'd be easy enough.
>>
>> Out of curiosity - can you point me to where it's an empty string?
>
>Only a handfull places (and I didn't check if those actually use the
>print functions before setting the real name):

Yeah, indeed, missed those.

Sent v2.

Thanks a lot!

>
>$ git grep alloc_netdev | grep \"\"
>drivers/net/hamradio/dmascc.c:    info->dev[0] = alloc_netdev(0, "",
>NET_NAME_UNKNOWN, dev_setup);
>drivers/net/hamradio/dmascc.c:    info->dev[1] = alloc_netdev(0, "",
>NET_NAME_UNKNOWN, dev_setup);
>drivers/net/ppp/ppp_generic.c:    dev = alloc_netdev(sizeof(struct
>ppp), "", NET_NAME_UNKNOWN,
>drivers/net/wireless/airo.c:    dev = alloc_netdev(sizeof(*ai), "",
>NET_NAME_UNKNOWN, ether_setup);
>net/atm/clip.c:    dev = alloc_netdev(sizeof(struct clip_priv), "",
>NET_NAME_UNKNOWN,
>
>Cheers,
>
>Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html