netdev - Re: [PATCH] iw_cxgb4: fix for 64-bit integer division

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140717.165230.570641364936685475.davem@davemloft.net>
Date:	Thu, 17 Jul 2014 16:52:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sergei.shtylyov@...entembedded.com
Cc:	hariprasad@...lsio.com, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, roland@...estorage.com,
	swise@...ngridcomputing.com, leedom@...lsio.com,
	nirranjan@...lsio.com, kumaras@...lsio.com, anish@...lsio.com
Subject: Re: [PATCH] iw_cxgb4: fix for 64-bit integer division

From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Date: Thu, 17 Jul 2014 22:44:42 +0400

> Hello.
> 
> On 07/17/2014 09:01 PM, Hariprasad Shenai wrote:
> 
>> Fixed error introduced in commit id 7730b4c (" cxgb4/iw_cxgb4: work
>> request
>> logging feature") while compiling on 32 bit architecture reported by
>> kbuild.
> 
>> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
>> ---
>>   drivers/infiniband/hw/cxgb4/device.c |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
> 
>> diff --git a/drivers/infiniband/hw/cxgb4/device.c
>> b/drivers/infiniband/hw/cxgb4/device.c
>> index df1f1b5..bb0de61 100644
>> --- a/drivers/infiniband/hw/cxgb4/device.c
>> +++ b/drivers/infiniband/hw/cxgb4/device.c
> [...]
>> @@ -150,7 +151,7 @@ static int wr_log_show(struct seq_file *seq, void
>> *v)
>>   	int prev_ts_set = 0;
>>   	int idx, end;
>>
>> -#define ts2ns(ts) ((ts) * dev->rdev.lldi.cclk_ps / 1000)
>> +#define ts2ns(ts) div64_ul((ts) * dev->rdev.lldi.cclk_ps , 1000)
> 
>    Don't need space before comma.

I killed the space when applying this patch, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html