netdev - Re: [PATCHv2 net-next] sunvnet: clean up objects created in vnet_new() on vnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140716.224432.83094029257457367.davem@davemloft.net>
Date:	Wed, 16 Jul 2014 22:44:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sowmini.varadhan@...cle.com
Cc:	dave.kleikamp@...cle.com, karl.volz@...cle.com,
	netdev@...r.kernel.org
Subject: Re: [PATCHv2 net-next] sunvnet: clean up objects created in
 vnet_new() on vnet_exit()

From: Sowmini Varadhan <sowmini.varadhan@...cle.com>
Date: Wed, 16 Jul 2014 10:02:26 -0400

> 
> Nothing cleans up the objects created by
> vnet_new(), they are completely leaked.
> 
> vnet_exit(), after doing the vio_unregister_driver() to clean
> up ports, should call a helper function that iterates over vnet_list
> and cleans up those objects. This includes unregister_netdevice()
> as well as free_netdev().
> 
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>
> Reviewed-by: Karl Volz <karl.volz@...cle.com>
> 
> ---
> v2: incorporated comments from David Miller.
> v3: muttrc config tweaks to avoid list-rejection
> and set up correct From/Message-ID headers.

Looks great, applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html