netdev - RE: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Jul 2014 18:21:44 +0000
From:	Rajesh Borundia <rajesh.borundia@...gic.com>
To:	Ethan Zhao <ethan.zhao@...cle.com>,
	Manish Chopra <manish.chopra@...gic.com>,
	Sony Chacko <sony.chacko@...gic.com>,
	netdev <netdev@...r.kernel.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	"ethan.kernel@...il.com" <ethan.kernel@...il.com>
Subject: RE: [PATCH V3] netxen: fix ethtool rx_dropped information in
 ethtool get_ethtool_stats()

> -----Original Message-----
> From: Ethan Zhao [mailto:ethan.zhao@...cle.com]
> Sent: Friday, July 18, 2014 9:13 AM
> To: Manish Chopra; Sony Chacko; Rajesh Borundia; netdev
> Cc: linux-kernel; ethan.kernel@...il.com; Ethan Zhao
> Subject: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool
> get_ethtool_stats()
> 
> netxen driver has implemented netxen_nic_get_ethtool_stats() interface,
> but it doesn't collect stats.rxdropped in driver, so we will get different
> rx_dropped statistic information while using ifconfig and ethtool.
> this patch fills stats.rxdropped field with data from net core with
> dev_get_stats() just as ixgbe driver did for some of its stats.

I think ethtool stats are adapter specific. Driver does not maintain
rx_dropped stats and we also don't get it from adapter.  I am not
sure if ethtool stats should match ifconfig stats as ifconfig also
adds net core stats to adapter stats.

If ethtool stats should report same values as ifconfig stats then
we may also need to fix tx_dropped statistics.

Thanks,
Rajesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html