netdev - Re: [Patch net-next] net_sched: hold tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1405661823.10255.86.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 18 Jul 2014 07:37:03 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Jamal Hadi Salim <jhs@...atatu.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [Patch net-next] net_sched: hold tcf_lock in netdevice notifier

On Thu, 2014-07-17 at 14:25 -0700, Cong Wang wrote:
> On Thu, Jul 17, 2014 at 11:17 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> >
> > Anyway, tcfm_dev should probably be RCU protected.
> >
> 
> Not sure how much we gain from making it RCU. We anyway
> need to hold that spinlock on fast path since we need to
> update its time stamp and stats.
> 
> I would just leave it as is.


I think you really should look at John Fastabend work, and many other
existing paths in the stack.

All this can be done lockless in fast path, using RCU and percpu
counters.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html