netdev - Re: [PATCH net-next v9 4/9] net: set name_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG-2HqX5wng4e+0=UAPPBt4cG2p0Yaoo0g31OUKticxfD_NrEA@mail.gmail.com>
Date:	Fri, 18 Jul 2014 10:59:04 +0200
From:	Tom Gundersen <teg@...m.no>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v9 4/9] net: set name_assign_type when setting
 names via ioctls

On Fri, Jul 18, 2014 at 1:20 AM, David Miller <davem@...emloft.net> wrote:
> From: Tom Gundersen <teg@...m.no>
> Date: Thu, 17 Jul 2014 10:06:05 +0200
>
>> @@ -2787,10 +2788,13 @@ static int gsm_create_network(struct gsm_dlci *dlci, struct gsm_netconfig *nc)
>>       pr_debug("create network interface");
>>
>>       netname = "gsm%d";
>> -     if (nc->if_name[0] != '\0')
>> +     if (nc->if_name[0] != '\0') {
>>               netname = nc->if_name;
>> -     net = alloc_netdev(sizeof(struct gsm_mux_net), netname,
>> -                        NET_NAME_UNKNOWN, gsm_mux_net_init);
>> +             name_assign_type = NET_NAME_USER;
>> +     }
>> +     net = alloc_netdev(sizeof(struct gsm_mux_net),
>> +                     netname, name_assign_type,
>> +                     gsm_mux_net_init);
>
> The indentation is now not correct.  For a function call, all arguments on the
> second and subsequent line, must start exactly at the first column after the
> openning parenthesis of the function call.

Indeed. Thanks, I'll fix this up.

Cheers,

Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html