netdev - Re: [PATCH] skbedit: allow the user to specify bitmask for mark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53CD0B7B.5060308@open-mesh.com>
Date:	Mon, 21 Jul 2014 14:45:47 +0200
From:	Antonio Quartulli <antonio@...n-mesh.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Antonio Quartulli <antonio@...hcoding.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH] skbedit: allow the user to specify bitmask for mark



On 21/07/14 14:31, Eric Dumazet wrote:
> On Mon, 2014-07-21 at 10:35 +0200, Antonio Quartulli wrote:
>> From: Antonio Quartulli <antonio@...n-mesh.com>
>>
>> The user may want to use only some bits of the skb mark in
>> his skbedit rules because the remaining part might be used by
>> something else.
>>
>> Introduce the "mask" parameter to the skbedit actor in order
>> to implement such functionality.
>>
>> When the mask is specified, only those bits selected by the
>> latter are altered really changed by the actor, while the
>> rest is left untouched.
>>
>> Cc: Jamal Hadi Salim <jhs@...atatu.com>
>> Signed-off-by: Antonio Quartulli <antonio@...n-mesh.com>
>> ---
>>  include/net/tc_act/tc_skbedit.h        |  1 +
>>  include/uapi/linux/tc_act/tc_skbedit.h |  2 ++
>>  net/sched/act_skbedit.c                | 20 +++++++++++++++++---
>>  3 files changed, 20 insertions(+), 3 deletions(-)
> 
> 
> You forgot to update tcf_skbedit_dump()
> 

Oh right! Thanks Eric.
I'll send v2

-- 
Antonio Quartulli


Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)