netdev - Re: [PATCH net-next 3/9] gue: Changes to ip_tunnel to support Generic UDP Encapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx9+i35xJjDmupJY7UA5quW=Cfmq2aQ6r3j7iJ0M8WmtHg@mail.gmail.com>
Date:	Sun, 20 Jul 2014 20:31:18 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 3/9] gue: Changes to ip_tunnel to support Generic
 UDP Encapsulation

On Thu, Jul 17, 2014 at 2:53 PM, David Miller <davem@...emloft.net> wrote:
> From: Tom Herbert <therbert@...gle.com>
> Date: Wed, 16 Jul 2014 21:14:44 -0700 (PDT)
>
>> This patch changes IP tunnel to support (secondary) encapsulation,
>> Generic UDP Encapsulation. Changes include:
>>
>> 1) Adding tun_hlen as the tunnel header length, encap_hlen as the
>> encapsulation header length (GUE), and hlen becomes the grand total
>> of these.
>> 2) Added generic function to handle IOCTLs
>> 3) Added IOCTLs to setup or remove encapsulation. This includes
>> uapi to configure encapsulation on a tunnel.
>> 4) Support to perform GUE encapsulation in ip_tunnel_xmit.
>>
>> Signed-off-by: Tom Herbert <therbert@...gle.com>
>
> Please extend the netlink interface for creating IP tunnels rather
> than adding things to the the deprecated ioctl interface.

Changing to the IP tunnel code to use netlink instead of ioctls looks
like a pretty major undertaking. I don't recall the tunnel ioctl's
being particularly problematic and extending them for GUE wasn't
particularly difficult. I can do this migration if it's really needed,
but I'd like to know that there's a real value behind it and it's not
just an academic exercise. Also, tuntap is still using ioctls, would
we need to move that to netlink for same reasons?

Thanks,
Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html