netdev - Re: [PATCH v3 net-next 0/2] net: print net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140720.203942.1635861091234493900.davem@davemloft.net>
Date:	Sun, 20 Jul 2014 20:39:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vfalico@...il.com
Cc:	netdev@...r.kernel.org, jbaron@...mai.com, edumazet@...gle.com,
	vyasevic@...hat.com, stephen@...workplumber.org, hkchu@...gle.com,
	bhutchings@...arflare.com, joe@...ches.com
Subject: Re: [PATCH v3 net-next 0/2] net: print net_device name/state more
 often

From: Veaceslav Falico <vfalico@...il.com>
Date: Thu, 17 Jul 2014 19:46:08 +0200

> Currently we use net_device->name only if it's the NETREG_REGISTERED
> reg_state, otherwise we return "(unregistered device)".
> 
> However, we always populate net_device->name on creation, so it's always
> available to us for use. The only caveat is that we might have a name like
> "eth%d", in which case we cannot use it as it might change in the future.
> 
> Also, the net_device might not be NETREG_UNREGISTERED when the function is
> called (_UNINITIALIZED, _UNREGISTERING, _RELEASED, _DUMMY), so it's
> misleading.
> 
> So, a better way would be to always return the dev->name in netdev_name(),
> unless it's in the form of "eth%d" or it's empty, then return
> "unnamed net_device". This way we'll always return the name in
> NETREG_REGISTERED reg_state, and also return it in other states, when
> possible.
> 
> Also, to be more verbose on non-NETREG_REGISTERED states, add a function
> netdev_reg_state(), which returns a string describing the state, and use it
> in netdev_printk()-related functions. If the dev is in NETREG_REGISTERED
> state then a void string is regurned and, thus, nothing changes.
> 
> After these two patches we'll have the same behaviour in the usual cases,
> and more verbose in non-standardad/buggy ones.
> 
> v2->v3:
> Correct the string for _UNINITIALIZED and warn on a bad reg_state,
> per Joe Perches's comments.
> 
> v1->v2:
> As Tom Gundersen suggested, there might be a case when we have an empty
> string as a name for a device, so account this also and return "unnamed
> device" for that case too.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html