netdev - Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140720.211813.942862864883062133.davem@davemloft.net>
Date:	Sun, 20 Jul 2014 21:18:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	benoit.taine@...6.fr
Cc:	linux-pci@...r.kernel.org, ath5k-devel@...ema.h4ckr.net,
	ath9k-devel@...ema.h4ckr.net, linux-hippi@...site.dk,
	dri-devel@...ts.freedesktop.org, linux-acenic@...site.dk,
	wil6210@....qualcomm.com, platform-driver-x86@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	linux-mips@...ux-mips.org, users@...x00.serialmonkey.com,
	linux-rdma@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	industrypack-devel@...ts.sourceforge.net,
	linux-can@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux-fbdev@...r.kernel.org, ath10k@...ts.infradead.org,
	linux-crypto@...r.kernel.org, MPT-FusionLinux.pdl@...gotech.com,
	devel@...uxdriverproject.org, xen-devel@...ts.xenproject.org,
	linux-pcmcia@...ts.infradead.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

From: Benoit Taine <benoit.taine@...6.fr>
Date: Fri, 18 Jul 2014 17:26:47 +0200

> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.
> 
> A simplified version of the semantic patch that makes this change is as
> follows (http://coccinelle.lip6.fr/):
> 
> // <smpl>
> 
> @@
> identifier i;
> declarer name DEFINE_PCI_DEVICE_TABLE;
> initializer z;
> @@
> 
> - DEFINE_PCI_DEVICE_TABLE(i)
> + const struct pci_device_id i[]
> = z;
> 
> // </smpl>
> 
> I have 103 patches ready, and will only send a few for you to judge if
> it is useful enough, and to prevent from spamming too much.

I'm fine with this wrt. the networking changes, but I don't think this should
be merged via my tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html