netdev - RE: [PATCH] clean up sparse cast warning in do_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17279EB0@AcuExch.aculab.com>
Date:	Mon, 21 Jul 2014 08:54:02 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'David Miller' <davem@...emloft.net>,
	"karoly.kemeny@...il.com" <karoly.kemeny@...il.com>
CC:	"jmorris@...ei.org" <jmorris@...ei.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] clean up sparse cast warning in do_ip_getsockopt

From: David Miller
> From: Karoly Kemeny <karoly.kemeny@...il.com>
> Date: Sun, 20 Jul 2014 13:30:17 +0200
> 
> > There is a sparse warning because of the implicit pointer cast in
> > do_ip_getsockopt.
> >
> > Signed-off-by: Karoly Kemeny <karoly.kemeny@...il.com>
> 
> Please format your subject line correctly, it should be of the form:
> 
> 	[PATCH] ${SUBSYSTEM}: Description.
> 
> Your's is missing the subsystem prefix, which in this case should
> be "ipv4: "
> 
> > -		msg.msg_control = optval;
> > +		msg.msg_control = (__force void*) optval;
> 
> Please put a space between "void" and "*" in the cast.

And remove the one after the ')' ?

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html