netdev - Re: [PATCH] atm: Remove fix me in solos-pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDOMVge=KHmModReK8PuK123kbJp8MmGpKhkjPdrAeP5gvg0g@mail.gmail.com>
Date:	Tue, 22 Jul 2014 13:47:37 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	chas williams - CONTRACTOR <chas@....nrl.navy.mil>
Cc:	linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] atm: Remove fix me in solos-pci

On Tue, Jul 22, 2014 at 7:43 AM, chas williams - CONTRACTOR
<chas@....nrl.navy.mil> wrote:
> Guy Ellis of Transverse says that Nathan Williams,
> nathan@...verse.com.au, will address this issue when he returns
> from vacation.  So let's just wait for the 'official' fix.
>
> On Tue, 22 Jul 2014 00:07:20 -0400
> Nicholas Krause <xerofoify@...il.com> wrote:
>
>> This removes a fix me as the default statement for solos_bh is correct
>> and needs no fixing.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
>> ---
>>  drivers/atm/solos-pci.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
>> index 943cf0d..58a0a8f 100644
>> --- a/drivers/atm/solos-pci.c
>> +++ b/drivers/atm/solos-pci.c
>> @@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
>>                               break;
>>
>>                       case PKT_COMMAND:
>> -                     default: /* FIXME: Not really, surely? */
>> +                     default:
>>                               if (process_command(card, port, skb))
>>                                       break;
>>                               spin_lock(&card->cli_queue_lock);
>
Very well then I just this is closed.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html