netdev - Re: [PATCH net-next 2/3] ethtool: add rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406055025.7427.7.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 22 Jul 2014 19:50:25 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Govindarajulu Varadarajan <_govind@....com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, ssujith@...co.com,
	benve@...co.com
Subject: Re: [PATCH net-next 2/3] ethtool: add rx_copybreak support

On Wed, 2014-07-23 at 00:05 +0530, Govindarajulu Varadarajan wrote:
> On Tue, 22 Jul 2014, Ben Hutchings wrote:
> 
> > On Tue, 2014-07-22 at 23:01 +0530, Govindarajulu Varadarajan wrote:
> >> This patch adds rx_copybreak support to ethtool.h header file.
> >> This is used to show/set rx_copybreak using ethtool.
> >>
> >> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>
> >> ---
> >>  include/uapi/linux/ethtool.h | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
> >> index e3c7a71..d2912ad 100644
> >> --- a/include/uapi/linux/ethtool.h
> >> +++ b/include/uapi/linux/ethtool.h
> >> @@ -433,10 +433,12 @@ struct ethtool_ringparam {
> >>  	__u32	rx_mini_max_pending;
> >>  	__u32	rx_jumbo_max_pending;
> >>  	__u32	tx_max_pending;
> >> +	__u32	rx_max_copybreak_pending;
> >>  	__u32	rx_pending;
> >>  	__u32	rx_mini_pending;
> >>  	__u32	rx_jumbo_pending;
> >>  	__u32	tx_pending;
> >> +	__u32	rx_copybreak_pending;
> >>  };
> >>
> >>  /**
> >
> > No, you can't rearrange UAPI structures like this.
> >
> 
> So I will move these 2 variables to the end of the struct?
> Also in ethtool-copy.h in ethtool.

No, you can't do that either.  Basically you can't change the size or
layout of any of the ethtool structures.

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)