netdev - Re: [PATCH net-next v3 1/3] net: sctp: Open out the check for Nagle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140722.133250.365865462579004160.davem@davemloft.net>
Date:	Tue, 22 Jul 2014 13:32:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: [PATCH net-next v3 1/3] net: sctp: Open out the check for Nagle

From: David Laight <David.Laight@...LAB.COM>
Date: Tue, 22 Jul 2014 08:59:08 +0000

> The check for Nagle contains 6 separate checks all of which must be true
> before a data packet is delayed.
> Separate out each into its own 'if (test) return SCTP_XMIT_OK' so that
> the reasons can be individually described.
> 
> Also return directly with SCTP_XMIT_RWND_FULL.
> Delete the now-unused 'retval' variable and 'finish' label from
> sctp_packet_can_append_data().
> 
> Signed-off-by: David Laight <david.laight@...lab.com>
> ---
> 
> Resend with corrected subject line.
> 
> Changes from v2:
> - Fix inverted test for 'inflight == 0'

Applied, but:

> +	if (inflight == 0)
> +		/* Nothing unacked */
> +		return SCTP_XMIT_OK;
> +	
   ^^^^^^

Trailing whitespace I had to fix up by hand.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html