netdev - Re: [PATCH net-next] cxgb4: Fix for SR-IOV VF initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53CEE9FB.3000405@chelsio.com>
Date:	Tue, 22 Jul 2014 15:47:23 -0700
From:	Casey Leedom <leedom@...lsio.com>
To:	David Miller <davem@...emloft.net>, hariprasad@...lsio.com
CC:	netdev@...r.kernel.org, nirranjan@...lsio.com, kumaras@...lsio.com,
	anish@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: Fix for SR-IOV VF initialization

   Sorry, Hari passed that patch off for review internally but I had 
just gotten back from a backpacking trip at the time.  I'll work with 
him to understand what the issue is.  Unfortunately I'm heading off on a 
second backpacking trip tomorrow so we probably won't be able to resolve 
this till next week.

Casey

On 07/22/14 15:34, David Miller wrote:
> From: Hariprasad Shenai <hariprasad@...lsio.com>
> Date: Tue, 22 Jul 2014 16:26:20 +0530
>
>> Commit 35b1de5 ("rdma/cxgb4: Fixes cxgb4 probe failure in VM when PF is exposed
>> through PCI Passthrough") introduced a regression, where VF failed to
>> initialize. This commit fixes it.
>>
>> Signed-off-by: Casey Leedom <leedom@...lsio.com>
>> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
> This commit message need to explain things better, how exactly was
> the regression introduced, what's exactly wrong with the current code?
>
> I actually can't figure it out myself, other than to say that maybe
> replacing things with:
>
> 	func = PCI_FUNC(pdev->devfn);
>   	if (func < ARRAY_SIZE(num_vf) && num_vf[func] > 0)
>   		if (pci_enable_sriov(pdev, num_vf[func]) == 0)
>
> would work equally as well.  That's precisely what the code was
> doing before the mentioned commit.
>
> Why do we have to iterate over _ALL_ functions of the PCI device,
> rather than just directly enable SRIOV on the one function whether
> it bet PCI_FUNC(pdev->devfn) or that WHOAMI value?
>
> You need to explain this so that people understand the how and the
> why of your changes.
>
> Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html