netdev - Re: [PATCH/RFC] net: Don't save mid batch datagram processing error for next recvmmsg call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140721.211754.1556855471792264676.davem@davemloft.net>
Date:	Mon, 21 Jul 2014 21:17:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	acme@...nel.org
Cc:	netdev@...r.kernel.org, caitlin.bestler@...il.com,
	chris.friesen@...driver.com, David.Laight@...LAB.COM,
	eliedebrauwer@...il.com, mtk.manpages@...il.com,
	nhorman@...driver.com, neleai@...nam.cz, paul@...l-moore.com,
	remi@...lab.net, steve@...gwyn.com
Subject: Re: [PATCH/RFC] net: Don't save mid batch datagram processing
 error for next recvmmsg call

From: Arnaldo Carvalho de Melo <acme@...nel.org>
Date: Mon, 21 Jul 2014 16:30:42 -0300

> From 5cf1a5c682c8bb0add9adfb5167a63f269136523 Mon Sep 17 00:00:00 2001
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> Date: Mon, 21 Jul 2014 12:39:56 -0300
> Subject: [PATCH 2/2] net: Don't save mid batch datagram processing error for
>  next recvmmsg call
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> When the call to the underlying per protocol recvmsg fails for some
> reason and we already have successfully processed at least one datagram
> in the batch, we were saving the error for the next recvmmsg (or
> recvmsg) call, so the user would eventually get notified of what
> happened.
> 
> This was found to be fraught with problems, as, for instance, errors
> could be notified for a different thread than a faulty one providing
> invalid buffers.
> 
> So just return the number of datagrams successfully received.
> 
> Reported-by: David Laight <David.Laight@...LAB.COM>
 ...
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

This is absolutely correct, any time we have a partial success we must
indicate success and the amount that was properly transferred, leaving
the error signalling for a subsequent retry (if any).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html