netdev - Re: [PATCH net-next v8 3/6] openvswitch: Add hash action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140723.144248.119709569087635224.davem@davemloft.net>
Date:	Wed, 23 Jul 2014 14:42:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org, azhou@...ira.com
Subject: Re: [PATCH net-next v8 3/6] openvswitch: Add hash action

From: Pravin B Shelar <pshelar@...ira.com>
Date: Tue, 22 Jul 2014 11:34:49 -0700

> OVS_ACTION_ATTR_HASH is set to 10 to maintain compatibility with
> existing userspace API.

I don't understand this.

> @@ -521,6 +544,7 @@ enum ovs_action_attr {
>  	OVS_ACTION_ATTR_PUSH_VLAN,    /* struct ovs_action_push_vlan. */
>  	OVS_ACTION_ATTR_POP_VLAN,     /* No argument. */
>  	OVS_ACTION_ATTR_SAMPLE,       /* Nested OVS_SAMPLE_ATTR_*. */
> +	OVS_ACTION_ATTR_HASH = 10,     /* struct ovs_action_hash. */
>  	__OVS_ACTION_ATTR_MAX
>  };

Do you have to force this to skip to '10' because of something
out-of-tree?  If so, that isn't a reasonable reason to do something
like this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html