lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Jul 2014 19:57:42 -0700 (PDT) From: David Miller <davem@...emloft.net> To: dborkman@...hat.com Cc: jgunthorpe@...idianresearch.com, netdev@...r.kernel.org, linux-sctp@...r.kernel.org, vyasevich@...il.com Subject: Re: [PATCH net v2] net: sctp: inherit auth_capable on INIT collisions From: Daniel Borkmann <dborkman@...hat.com> Date: Tue, 22 Jul 2014 15:22:45 +0200 > Jason reported an oops caused by SCTP on his ARM machine with > SCTP authentication enabled: ... > While we already had various kind of bugs in that area > ec0223ec48a9 ("net: sctp: fix sctp_sf_do_5_1D_ce to verify if > we/peer is AUTH capable") and b14878ccb7fa ("net: sctp: cache > auth_enable per endpoint"), this one is a bit of a different > kind. ... > The correct fix is to update to the new peer.auth_capable > value as well in the collision case via sctp_assoc_update(), > so that in case the collision migrated from 0 -> 1, > sctp_auth_asoc_init_active_key() can properly recalculate > the secret. This therefore fixes the observed server panic. > > Fixes: 730fc3d05cd4 ("[SCTP]: Implete SCTP-AUTH parameter processing") > Reported-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com> > Signed-off-by: Daniel Borkmann <dborkman@...hat.com> > Tested-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists