lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jul 2014 00:53:15 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Pablo Neira Ayuso <pablo@...filter.org>, David Miller <davem@...emloft.net> Cc: netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org Subject: [PATCH] netfilter: nf_sockopt_find() should return ERESTARTSYS From: Eric Dumazet <edumazet@...gle.com> getsockopt() or setsockopt() sometimes returns -EINTR instead of -ENOPROTOOPT, causing headaches to application developers. This is because unsupported commands might go through nf_sockopt_find() and this function returns -EINTR instead of -ERESTARTSYS if a signal is pending. Signed-off-by: Eric Dumazet <edumazet@...gle.com> --- net/netfilter/nf_sockopt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_sockopt.c b/net/netfilter/nf_sockopt.c index f042ae521557..37181447715b 100644 --- a/net/netfilter/nf_sockopt.c +++ b/net/netfilter/nf_sockopt.c @@ -66,7 +66,7 @@ static struct nf_sockopt_ops *nf_sockopt_find(struct sock *sk, u_int8_t pf, struct nf_sockopt_ops *ops; if (mutex_lock_interruptible(&nf_sockopt_mutex) != 0) - return ERR_PTR(-EINTR); + return ERR_PTR(-ERESTARTSYS); list_for_each_entry(ops, &nf_sockopts, list) { if (ops->pf == pf) { -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists