netdev - Re: [PATCH net-next 2/6] net: bcmgenet: add missing blank line after declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2014 21:35:26 -0700
From:	Joe Perches <joe@...ches.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 2/6] net: bcmgenet: add missing blank line
 after declaration

On Tue, 2014-07-22 at 10:55 -0700, Florian Fainelli wrote:
> checkpatch flagged a bunch of problems in bcmgenet.h with: WARNING:
> Missing a blank line after declarations, fix them.
[]
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
[]
> @@ -438,6 +438,7 @@ struct bcmgenet_mib_counters {
>  struct enet_cb {
>  	struct sk_buff      *skb;
>  	void __iomem *bd_addr;
> +
>  	DEFINE_DMA_UNMAP_ADDR(dma_addr);
>  	DEFINE_DMA_UNMAP_LEN(dma_len);
>  };
> @@ -503,6 +504,7 @@ struct bcmgenet_tx_ring {
>  	unsigned int	prod_index;	/* Tx ring producer index SW copy */
>  	unsigned int	cb_ptr;		/* Tx ring initial CB ptr */
>  	unsigned int	end_ptr;	/* Tx ring end CB ptr */
> +
>  	void (*int_enable)(struct bcmgenet_priv *priv,
>  				struct bcmgenet_tx_ring *);
>  	void (*int_disable)(struct bcmgenet_priv *priv,

checkpatch false positives.

The first is a macro definition, the second is a function pointer.

Please use the version in -next.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html