netdev - Re: [PATCH 2/6] net/macb: add scatter-gather hw feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53CF6808.4070206@atmel.com>
Date:	Wed, 23 Jul 2014 09:45:12 +0200
From:	Cyrille Pitchen <cyrille.pitchen@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	<nicolas.ferre@...el.com>, <linux-arm-kernel@...ts.infradead.org>,
	<netdev@...r.kernel.org>, <soren.brinkmann@...inx.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] net/macb: add scatter-gather hw feature

Le 21/07/2014 06:13, David Miller a écrit :
> From: Cyrille Pitchen <cyrille.pitchen@...el.com>
> Date: Fri, 18 Jul 2014 16:21:14 +0200
> 
>> +		if (tx_skb->mapped_as_page) {
>> +			dma_unmap_page(&bp->pdev->dev, tx_skb->mapping,
>> +				       tx_skb->size, DMA_TO_DEVICE);
>> +		} else {
>> +			dma_unmap_single(&bp->pdev->dev, tx_skb->mapping,
>> +					 tx_skb->size, DMA_TO_DEVICE);
>> +		}
> 
> Please do not use curly braces for basic block composed of a single statement.
> 
Hi David,

thanks for your review, I'll fix it in the next series of patch.

Regards,

Cyrille
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html