lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 23 Jul 2014 08:25:55 -0500
From:	Tom Lendacky <thomas.lendacky@....com>
To:	<weiyj_lk@....com>, Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>
CC:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] amd-xgbe: Fix error return code in xgbe_probe()

On 07/22/2014 07:59 PM, weiyj_lk@....com wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Fix to return a negative error code from the setting real tx queue
> count error handling case instead of 0.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
>   drivers/net/ethernet/amd/xgbe/xgbe-main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-main.c b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> index c83584a..5a1891f 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-main.c
> @@ -339,7 +339,8 @@ static int xgbe_probe(struct platform_device *pdev)
>   	/* Calculate the number of Tx and Rx rings to be created */
>   	pdata->tx_ring_count = min_t(unsigned int, num_online_cpus(),
>   				     pdata->hw_feat.tx_ch_cnt);
> -	if (netif_set_real_num_tx_queues(netdev, pdata->tx_ring_count)) {
> +	ret = netif_set_real_num_tx_queues(netdev, pdata->tx_ring_count);
> +	if (ret) {
>   		dev_err(dev, "error setting real tx queue count\n");
>   		goto err_io;
>   	}
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists