lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Jul 2014 17:41:23 +0200 From: Manuel Lauss <manuel.lauss@...il.com> To: David Laight <David.Laight@...lab.com> Cc: Linux-MIPS <linux-mips@...ux-mips.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH 2/6] MIPS: Alchemy: move ethernet registers to ethernet driver On Wed, Jul 23, 2014 at 4:58 PM, David Laight <David.Laight@...lab.com> wrote: > From: Manuel Lauss >> Move the register offsets and bit descriptions from the au1000.h header >> to their only user, the au1000_eth.c driver. > > Personally I'd use 2 header files. > One for the private data and one for the public data. > It can be much easier to read code if the structure definitions are in > a header file. au1000.h now only contains core chip-specific code; this is the last driver which has driver-specific definitions living in the "chip-global" headers. Eventually I'd like to get rid of au1000_eth.h as well :) Manuel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists