netdev - Re: [PATCHv2] skbedit: allow the user to specify bitmask for mark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406133557.3363.11.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 23 Jul 2014 18:39:17 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Antonio Quartulli <antonio@...hcoding.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	sergei.shtylyov@...entembedded.com,
	Antonio Quartulli <antonio@...n-mesh.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCHv2] skbedit: allow the user to specify bitmask for mark

On Wed, 2014-07-23 at 10:03 +0200, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@...n-mesh.com>
> 


>  
> @@ -160,6 +174,10 @@ static int tcf_skbedit_dump(struct sk_buff *skb, struct tc_action *a,
>  	    nla_put(skb, TCA_SKBEDIT_MARK, sizeof(d->mark),
>  		    &d->mark))
>  		goto nla_put_failure;
> +	if ((d->flags & SKBEDIT_F_MASK) &&
> +	    nla_put(skb, TCA_SKBEDIT_MASK, sizeof(d->mask),
> +		    &d->mark))

typo here : d->mask is better.

Or even better :

	nla_put_u32(skb, TCA_SKBEDIT_MASK, d->mask)

> +		goto nla_put_failure;
>  	t.install = jiffies_to_clock_t(jiffies - d->tcf_tm.install);
>  	t.lastuse = jiffies_to_clock_t(jiffies - d->tcf_tm.lastuse);
>  	t.expires = jiffies_to_clock_t(d->tcf_tm.expires);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html