netdev - Re: [PATCH net-next v3 1/5] net-timestamp: extend SCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140723.211256.2143360320648788946.davem@davemloft.net>
Date:	Wed, 23 Jul 2014 21:12:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	willemb@...gle.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	richardcochran@...il.com
Subject: Re: [PATCH net-next v3 1/5] net-timestamp: extend SCM_TIMESTAMPING
 ancillary data struct

From: Willem de Bruijn <willemb@...gle.com>
Date: Tue, 22 Jul 2014 11:45:30 -0400

> There are a few alternatives, but none as simple, so this is better
> left to a separate patch. With skb_shinfo(skb)->syststamp deprecated
> for all but the octeon legacy use case, it is possible to repurpose
> those bytes for new uses in a union, including for a new u16 ts_key.
> The sk would still have to grow by a new field, though, e.g.,
> ts_counter. I have to think about this a bit more first.

I can't believe we're going to hold onto syststamp just for one
odd-ball MIPS ethernet driver.  Really?

I think putting in whatever work is necessary to convert Octeon over
to exposing a proper PTP device is much better than having this
syststamp thing rot in our data structures forever.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html