netdev - Re: [PATCH nf-next] netfilter: xt_hashlimit: perform garbage collection from process context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140724110804.GA15610@salvia>
Date:	Thu, 24 Jul 2014 13:08:04 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Florian Westphal <fw@...len.de>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Patrick McHardy <kaber@...sh.net>,
	netfilter-devel@...r.kernel.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH nf-next] netfilter: xt_hashlimit: perform garbage
 collection from process context

On Thu, Jul 24, 2014 at 10:27:44AM +0200, Florian Westphal wrote:
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> > 
> > xt_hashlimit cannot be used with large hash tables, because garbage
> > collector is run from a timer. If table is really big, its possible
> > to hold cpu for more than 500 msec, which is unacceptable.
> > 
> > Switch to a work queue, and use proper scheduling points to remove
> > latencies spikes.
> > 
> > Later, we also could switch to a smoother garbage collection done
> > at lookup time, one bucket at a time...
> > 
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> 
> Reviewed-by: Florian Westphal <fw@...len.de>

Applied, thanks Eric!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html