netdev - Re: [net-next 03/14] ixgbe: fix use of list_for_each in ixgbe_enumerate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1406220481.30819.1.camel@jekeller-desk1.amr.corp.intel.com>
Date:	Thu, 24 Jul 2014 16:48:01 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"nhorman@...hat.com" <nhorman@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next 03/14] ixgbe: fix use of list_for_each in
 ixgbe_enumerate_functions

On Thu, 2014-07-24 at 06:13 -0700, Jeff Kirsher wrote:
> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> Fix a bug in the misuse of the list_for_each macro to loop over every
> entry in the bus_list. Instead of attempting to loop over the list from
> a random entry point, go up to the bus and use the real list_head entry
> point. This prevents the possible read or write of unallocated or
> incorrectly addressed memory.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---

Realized I forgot to add, for those that might be interested (stable
kernel maintainers?)

Fixes: e027d1aec4bb ("ixgbe: call pcie_get_mimimum_link to check if device has enough bandwidth")

Thanks,
Jake